Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put paket.references inside msbuild project for .net sdk projects #2019

Closed
enricosada opened this issue Nov 15, 2016 · 2 comments
Closed

put paket.references inside msbuild project for .net sdk projects #2019

enricosada opened this issue Nov 15, 2016 · 2 comments

Comments

@enricosada
Copy link
Collaborator

Atm with #1977 the core3paket.csproj.references file is used to add packages ref on restore, like before.

I think the references can be included inside the fsproj:

<ItemGroup>
    <PaketReference>Newtonsoft.Json</PaketReference>
<ItemGroup>

or as property separated by ; (easier for merge, like TargetFrameworks)

<PropertyGroup>
    <PaketReference>Newtonsoft.Json;log4net</PaketReference>
<PropertyGroup>

And remove the need for a core3paket.csproj.references (one file less), so all project files are self-contained

On dotnet restore, the paket target will:

  • will read the PaketReference items/property
  • create an obj\core3paket.csproj.references (inside obj dir)
  • and call paket passing full path of obj\core3paket.csproj.references instead of infer location is near the .csproj

Like that the paket support seems more first class (like PackageReference), the csproj/fsproj is not verbose, and conditional based on framework or other is normal sintax ( Condition="'$(TargetFramework)' == 'net46'" ) already used for defined/props/packages

@forki
Copy link
Member

forki commented Nov 16, 2016

I'm bit undecided on that right now. I'm not completely against it but I would wait a bit.

@enricosada enricosada changed the title put paket.references inside msbuild project for sdk preview3 put paket.references inside msbuild project for .net sdk projects Jan 24, 2018
@enricosada
Copy link
Collaborator Author

enricosada commented Jan 24, 2018

Closing, hard to implement correctly, different than current usage and no big gains atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants