-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major bug: Paket adds native references to .vcxproj file as if they are managed references (assemblies) #1658
Comments
Can you please come up with a small repro that has this issue and a csproj BTW: it's not a major bug it's just not really supported, yet. ;-) but I In paket.dependencies we have And in paket.references same packages also designated as native: When Packet Install executes it adds references to .vcxproj file, but does What is wrong in that fragment is that Reference element should instead be Should be relatively easy and straightforward fix, but it is blocking use Konstantin — |
Ok, working on it. From: Steffen Forkmann [mailto:[email protected]] Can you please come up with a small repro that has this issue and a csproj BTW: it's not a major bug it's just not really supported, yet. ;-) but I In paket.dependencies we have And in paket.references same packages also designated as native: When Packet Install executes it adds references to .vcxproj file, but does What is wrong in that fragment is that Reference element should instead be Should be relatively easy and straightforward fix, but it is blocking use Konstantin — — |
Trivial example is here: https://goo.gl/5Uxjjx |
If it compiles - it is probably fine! Frankly I also don't have a ton of experience with native NuGet packages. Playing by the ear. :) |
I don't know if it compiles - I'm missing some C++ build tools. I will just release this in v3 channel so you can test. |
Is there a build for me to try? |
I wish. Deutsche Telekom killed my Internet and tethering did not work... I will let you know
|
push succeeded please test latest paket 3.0 beta version. thx |
It does the right thing, but I cannot test it beyond the very first project, because #1657 is in the way. I have provided a small repro for that issue. |
yeah. hopefully I can take a look tomorrow. Developing a package manager without good internet connection is no fun. |
In paket.dependencies we have
framework: native
content: none
redirects: off
source https://www.nuget.org/api/v2/
nuget boost_date_time-vc140 1.60.0.0
nuget boost_filesystem-vc140 1.60.0.0
nuget boost_system-vc140 1.60.0.0
And in paket.references same packages also designated as native:
cpprestsdk.v140.winxp.msvcstl.static.rt-dyn framework: native
boost_filesystem-vc140 framework: native
boost_date_time-vc140 framework: native
boost_system-vc140 framework: native
When Packet Install executes it adds references to .vcxproj file, but does it like that:
What is wrong in that fragment is that
Reference
element should instead beNativeReference
or it confuses build system badly as it expect References to be proper .NET assemblies.Should be relatively easy and straightforward fix, but it is blocking use from further development with Paket.
Konstantin
The text was updated successfully, but these errors were encountered: