pack fails for f# projects using ReflectedDefinition attributes

[haraldsteinlechner]

This issue is related to a problem in FSharp.Data, where our pull request is in review (seealso: fsprojects/FSharp.Data#919)
However, since the problem occurs in paket and testing is difficult i created this issue, serving as solid test case as well as documentation for the problem.

Description

pack fails internally in AssemblyReader.fs when parsing assembly metadata.

Repro steps

#1596 in my fork haraldsteinlechner@7b0680a shows the problem.

Expected behavior

packing simply works

Actual behavior

System.Exception : Paket failed with:
decodeILCustomAttribData: error parsing type in custom attribute blob: The given assembly name or codebase was invalid. (Exception from HRESULT: 0x80131047)

Known workarounds

my FSharp.Data fork fixes the problem: haraldsteinlechner/FSharp.Data@d4a3075

[forki]

we could point https://github.com/fsprojects/Paket/blob/master/paket.dependencies#L9 to your fork if you need a quick fix

[haraldsteinlechner]

i did this here: https://github.com/haraldsteinlechner/Paket/tree/assemblyMetadataFix
but still waiting for integration tests to complete. Although the involved code is tricky, we could give it a try and use my fix.
(pull request after test completion)

[forki]

this is released. Please set it back to FSharp.Data when they merged your PR

[forki]

and thanks!