Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert-from-nuget should add .paket folder to .sln #158

Closed
bartelink opened this issue Sep 24, 2014 · 4 comments
Closed

convert-from-nuget should add .paket folder to .sln #158

bartelink opened this issue Sep 24, 2014 · 4 comments

Comments

@bartelink
Copy link
Member

I'm testing conversion of hyprlinkr. It has a .nuget folder in the .sln.

I think it would be nice for a paket folder to be added to the .sln which contains links to the paket.dependencies and paket.lock as its' the first think I'd ordinarilly be doing myself (I assumed it already did this to be honest).

Also, I like the way paket.references files get added to the .proj files but I think they should be as high in the Solution view as possible - esp as in a .fsproj the project system won't just sort them alphabetically [toward the end] (and there is typically no longer a packages.config for it to sort alphabetically beside. Ideally they'd sit just below the References folder (this will make even more sense in an AspNetVNext world where References will include NuGets.

I accept that these things might be subjective so thoughts?

@forki
Copy link
Member

forki commented Sep 26, 2014

  1. I agree. convert-from-nuget should do .nuget => .paket conversion. We have all the stuff available. @theimowski can you take a look?

  2. I think that's a good idea? What about C# projects - how can we influence the order?

@bartelink
Copy link
Member Author

re 1) BTW I'm sure its obvious but not just conversion/renaming - should always add even if there was no .nuget sln folder?

re 2) Aside from creating a folder I can't think of any way as it's alphabetical case insensitive (but it'll sit where packages.config used to sit so that's not the end of the world - main thing is it's in the csproj)

re aspnetvnext I wonder what the default rendering is - as the inclusion of .cs files in whatever the projs are called is now called, perhaps implicitly added ones are after explicit ones?

@theimowski
Copy link
Member

  1. should lock and dependencies files be also moved to the .paket dir or stay under the root dir?

@forki
Copy link
Member

forki commented Sep 30, 2014

no. please keep paket.dependencies + paket.lock in root

@forki forki closed this as completed Sep 30, 2014
tpetricek added a commit that referenced this issue Jun 3, 2015
Adding backwards compatibility with previous scaffold conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants