Redirects for assemblies in the GAC are removed by paket

[freeranger]

Description

I have a solution which needs this redirect:

<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <dependentAssembly>
        <assemblyIdentity name="System.Web.Extensions" publicKeyToken="31bf3856ad364e35" />
        <bindingRedirect oldVersion="1.0.0.0-1.1.0.0" newVersion="4.0.0.0" />
      </dependentAssembly>
    </assemblyBinding>

Which is being removed by paket.

System.Web.Extensions is in the GAC.
I would expect paket to leave along any redirects for GAC registered assemblies by default or at least provide a configuration option where we can specify the redirects we want to keep

[forki]

When is that happening? Can you provide a repro sample? /cc @isaacabraham
On Apr 6, 2016 1:04 PM, "freeranger" [email protected] wrote:

Description

I have a solution which needs this redirect:

Which is being removed by paket.

System.Web.Extensions is in the GAC.
I would expect paket to leave along any redirects for GAC registered
assemblies by default or at least provide a configuration option where we
can specify the redirects we want to keep

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1574

[freeranger]

paket convert-from-nuget --force
is removing all redirects.
the paket.dependencies file only lets you specify keeping redirects for package references, not for GAC references

[forki]

AFAIK we should not touch GAC references in the redirects.

// @mrinaldi

[forki]

mhm. I tried to reproduce in b099dfe, but test is green. What am I missing?

[freeranger]

You are doing a paket "install --force" whereas the problem happens when you do a paket convert-from-nuget --force

[forki]

@theimowski are we doing something special in that command?

@freeranger can you reset the config files after conversion and rerun install? Does this keep the entries?

[freeranger]

@forki yes, if I re-add them after conversion then they are preserved

[forki]

Ok so it's something we do in convert.
On Apr 7, 2016 2:21 PM, "freeranger" [email protected] wrote:

@forki https://github.com/forki yes, if I re-add them after conversion
then they are preserved

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1574 (comment)

[theimowski]

update is invoked as the last step in convert: https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/NugetConvert.fs#L392-L395, but it has Force = true; Hard = true; Redirects = true

[forki]

Mhm I guess it's the --hard flag. But I think it should not remove GAC stuff, right?

[theimowski]

Can't tell for sure @isaacabraham

[forki]

ok confirmed. it's the --hard flag

[freeranger]

Thanks for the quick turnaround fellas - works like a charm now 👍