-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket Pack builds bad pakage when specifying relative target path external to package directory. #1472
Comments
I can't really reproduce, but please try latest version. I changed something that might be related |
globbing from 2.50.7 seems to be somewhat broken: this is a reproducible case: it probably does not cover all cases, i see the paket.template being packaged too in the project i am currently working on, but i don't have a simple reproducible case as of now |
We changed pack in 2.50.9 - can you please try with that version? |
I did, the output is from 2.50.9. 2.50.6 is the last that works fine. |
so I revert 3fcac1d and await a repro from @galaxystar!? |
Sounds reasonable to me. Alternatively I can pin Paket's version again, seems we need a mechanism to do this over all our repos anyway. |
This reverts commit 3fcac1d. Conflicts: RELEASE_NOTES.md
@flowsprenger please try latest |
@forki works again :) |
Would be great if you could contribute your repro as an integration test so
|
@galaxystar since you seem to use unity, maybe its worth having a look at https://github.com/wooga/Paket.Unity3D/ which allows to install using paket.unity3.exe and paket.unity3d.reference files. @forki alright, shall have a look at how to do that |
thx would be of great help |
@forki I just tried 2.50.10 with the same (wrong) results. I have a temp work around (using @flowsprenger I looked into Paket.Unity3D. It seems to be abandoned. No forks, no changes in 6 months, 5 issues, most of which were unaddressed and their mono build seems to be failing. I'd prefer to stick with vanilla Paket as it seems to do everything I need it to and gives me the flexibility to swap packages in/out as I see fit (such as when switching platforms). |
I'm not near a pc for 2 weeks but if you can come up with a repro I'll try
|
I just tried with 2.50.10 and it worked locally, but gave me problems on my build machine. I then went through the full installation process for Mac (downloaded repository and installed using the install script) and it worked correctly. I must have had some frankenstein installation through my manual installation process. Thanks for all the help, I really appreciate it! |
…bbing_1472 integration test for globbing broken when trying to fix #1472
Paket 2.50.6.0, 3.0.0.40-alpha. Running on Mac.
When I use a target path that is external (and non absolute) to a directory outside of the /packages/group/ directory it results in duplicate files, where the duplicate files are at the wrong path.
I'm using relative paths because I want the install/update for some of my packages to be deployed somewhere other than the packages directory. I know it's an atypical approach but it should still be an approach that is supported.
When I list the files in the package using
unzip -l mypackage.1.0.3.nupkg
:A couple things to note:
My
project.template
fileThe text was updated successfully, but these errors were encountered: