-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket and C++ projects? #1467
Comments
yes please give details. Maybe it's just fixing https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/ProjectFile.fs#L229 and https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/ProjectFile.fs#L108 |
I will try it out |
what is the correct project file ending? |
Looks encouraging... But we are brave! My colleague Tommy, who mostly cares about C++ will be looking at it shortly. Thanks for the swift response! |
yeah I added a small integration test with a "file new C++ project". It seems to reference it correctly, but I assume this is only the tip of the iceberg. |
Thanks, I plan on giving a go today. A quick question will be what do you recommend we put for the "framework" or should I just leave that out? |
in the dependencies file? Good question. I guess start by leaving it out. |
to clarify: I want to make this useful for C++, but since I don't use C++ myself it will likely involve some ping pong during the initial dev/testing phase. |
Yea, in the dependencies file. I'm going to try it empty. In nuget we would do something like this: . I'm giving 2.50 a try and will let you know soon the result. |
better remove the line completey (at least for now) we can add it back later when we know the correct framework monikers. |
This was able to include the library files correctly. However, one thing that it was missing was the target files. An example is:
When following the nuget instructions for this package: https://github.com/Microsoft/cpprestsdk/wiki/Getting-Started-Tutorial |
ok will look at this tommorow. |
@tommysu can you please send me the project that you get after "getting started" using Nuget? sforkmann at gmail |
Sent. |
I'm pushing a new version but I'm not sure if the "when conditions" are generated properly. So I assume we need to iterate on that. But it is progress ;-) |
Ok release failed. I broke another integration test. Good thing that we have these in place. Will look into this tomorrow. |
Ok the version is released |
It appears that the project file will get corrupted it. It generates a When condition with uneven number of ' marks. And Visual Studio will complain of An unexecpted token "=="
|
ah. my copy paste bug. fixing it now. |
fixed that |
Sorry for going back and forth. But it looks like the target file path is incorrect.
It should be something like \build\native$(...).targets |
Ah I see. Yes this is completely different to the other target framework
|
Ok another fix deployed. Please run "paket clear-cache" before you try again. |
Awesome, that works! I'll let you know if I run into any more issues. |
Wow. Cool.
|
Closing this one. Please open new issues for the new issues you find. |
My colleague reported that Paket does not work right for C++ projects, while NuGet does.
What is the design decision here - is it even supposed to support C++ projects or not?
If it supposed to support C++, then I gather more details about the problem from my colleague.
If it is not supposed to support C++, then can we have Paket and NuGet used in the same solution?
Thank you!
Konstantin
The text was updated successfully, but these errors were encountered: