Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a dependent assembly is .NET 4.5.1, and the current project is .NET 4.5, it will silently fail #1442

Closed
sharpe5 opened this issue Jan 29, 2016 · 7 comments · Fixed by #1445

Comments

@sharpe5
Copy link

sharpe5 commented Jan 29, 2016

How about a meaningful error if paket is failing to import dependent assembles, due to a .NET framework mismatch?

Scenario: We had an entire team of 10 developers trying to fix issues with Paket. No matter what we did, a "paket install" would not import a required assembly.

Eventually, after 4 hours and some senior developers had tried and failed to fix the issue, we realized that the dependent packaged assembly was .NET v4.5.1, which wouldn't load into a project configured for .NET 4.5.

@forki
Copy link
Member

forki commented Jan 29, 2016

Unfortunately that is not always an error. Many packages are only used for some .NET framework versions and have counterparts in other nuget packages or the framework itself for other framework versions.

That said: would it have helped you if we provide a big yellow warning? We could warn if a framework was selected in the project but the install conditions create a empty lib set.

@forki
Copy link
Member

forki commented Jan 29, 2016

It could look like this:

image

@forki
Copy link
Member

forki commented Jan 29, 2016

corresponding PR #1445

@sharpe5
Copy link
Author

sharpe5 commented Jan 29, 2016

Thank you for your quick reply. It would definitely help if there was a yellow warning.

In Visual Studio, unfortunately, I think the "Output" view is monochrome if the Paket Extension Tool is used, so it might be an idea to empahasize it with some surrounding stars.

On 29 January 2016 15:42:03 GMT+00:00, Steffen Forkmann [email protected] wrote:

Unfortunately that is not always an error. Many packages are only used
for some .NET framework versions and have counterparts in other nuget
packages or the framework itself for other framework versions.

That said: would it have helped you if we provide a big yellow warning?
We could warn if a framework was selected in the project but the
install conditions create a empty lib set.


Reply to this email directly or view it on GitHub:
#1442 (comment)

@sharpe5
Copy link
Author

sharpe5 commented Jan 29, 2016

Brilliant, that would work nicely!!

On 29 January 2016 16:46:55 GMT+00:00, Steffen Forkmann [email protected] wrote:

It could look like this:

image


Reply to this email directly or view it on GitHub:
#1442 (comment)

@CumpsD
Copy link
Contributor

CumpsD commented Apr 7, 2016

Any way to be smarter then the resolver and ask paket to reference a "wrong" target framework? :)

@forki
Copy link
Member

forki commented Apr 8, 2016

Only manually
On Apr 8, 2016 12:29 AM, "David Cumps" [email protected] wrote:

Any way to be smarter then the resolver and ask paket to reference a
"wrong" target framework? :)


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#1442 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants