Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget feed v3 only #1143

Closed
xavierzwirtz opened this issue Oct 15, 2015 · 9 comments
Closed

Nuget feed v3 only #1143

xavierzwirtz opened this issue Oct 15, 2015 · 9 comments

Comments

@xavierzwirtz
Copy link
Contributor

Working on a private nuget feed implementing the v3 nuget 3 spec. If I set the feed in paket.dependencies to

source https://myfeed.org/api/v3

Paket uses the v2 methods to attempt to load the data. I would like to not have to implement the v2 api in my feed, its rather complicated for what I need to do. Any way to have Paket use the v3 api methods for a specific url? Maybe with an argument to source that hard codes the api version.

source https://myfeed.org/api/v3 nugetv3
@forki
Copy link
Member

forki commented Oct 15, 2015

Currently paket accepts only v2 urls and automatically tries to compute the
v3 url and then tests this url.

You could look into this v3 url discovery (in NugetV3.fs) to make it work
for your url.
On Oct 16, 2015 12:36 AM, "Xavier Zwirtz" [email protected] wrote:

Working on a private nuget feed implementing the v3 nuget 3 spec. If I set
the feed in paket.dependencies to

source https://myfeed.org/api/v3

Paket uses the v2 methods to attempt to load the data. I would like to not
have to implement the v2 api in my feed, its rather complicated for what I
need to do. Any way to have Paket use the v3 api methods for a specific
url? Maybe with an argument to source that hard codes the api version.

source https://myfeed.org/api/v3 nugetv3


Reply to this email directly or view it on GitHub
#1143.

@forki
Copy link
Member

forki commented Oct 15, 2015

(you are the first person that tells me there are nuget v3 servers that
don't implement v3)
On Oct 16, 2015 12:40 AM, "Steffen Forkmann" [email protected] wrote:

Currently paket accepts only v2 urls and automatically tries to compute
the v3 url and then tests this url.

You could look into this v3 url discovery (in NugetV3.fs) to make it work
for your url.
On Oct 16, 2015 12:36 AM, "Xavier Zwirtz" [email protected]
wrote:

Working on a private nuget feed implementing the v3 nuget 3 spec. If I
set the feed in paket.dependencies to

source https://myfeed.org/api/v3

Paket uses the v2 methods to attempt to load the data. I would like to
not have to implement the v2 api in my feed, its rather complicated for
what I need to do. Any way to have Paket use the v3 api methods for a
specific url? Maybe with an argument to source that hard codes the api
version.

source https://myfeed.org/api/v3 nugetv3


Reply to this email directly or view it on GitHub
#1143.

@xavierzwirtz
Copy link
Contributor Author

There isnt one yet ;)

@xavierzwirtz
Copy link
Contributor Author

I am working on a pr that will make Paket support a nuget feed that does not implement the v2 OData api.

I think the source parameter needs to support explicitly setting the api version, ala source https://myfeed.org/api/v3 nugetv3

Would you have any objections to that?

@xavierzwirtz
Copy link
Contributor Author

For backwards compatibility any source that does not have a version explicitly set is assumed to be nugetv2. Only issue I could see with this is if some one was using a custom feed url that has a space in it that is not url encoded to %20.

@xavierzwirtz
Copy link
Contributor Author

A lot of the tests specify a source with only a starting quote, not an ending quote:
source "http://nuget.org/api/v2

Does that functionality need to stay? Its making adding version to the parse a pain.

@forki
Copy link
Member

forki commented Oct 22, 2015

I don't really understand why you need to change the parser.
I think the only interesting part is https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/NuGetV3.fs#L30

@xavierzwirtz
Copy link
Contributor Author

I am being an idiot. I was going to make it where you had to explicitly say that a source supported V3, no reason to do that though. 🙈

@xavierzwirtz
Copy link
Contributor Author

Implemented by #1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants