NullReferenceException in applyBindingRedirects during "update nuget …

…package" - fixes #1074
fsprojects · Sep 21, 2015 · 8b606c5 · 8b606c5
1 parent d869b9b
commit 8b606c5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,3 +1,6 @@
+#### 2.3.1 - 21.09.2015
+* BUGFIX: NullReferenceException in applyBindingRedirects during "update nuget package" - https://github.com/fsprojects/Paket/issues/1074
+
 #### 2.3.0 - 21.09.2015
 * Binding redirects from target platform only - https://github.com/fsprojects/Paket/pull/1070
 * Allow to enable redirects per package - http://fsprojects.github.io/Paket/nuget-dependencies.html#redirects-settings

diff --git a/src/Paket.Core/ProjectFile.fs b/src/Paket.Core/ProjectFile.fs
@@ -671,18 +671,21 @@ type ProjectFile =
             KnownTargetProfiles.FindPortableProfile profile
         | _ ->
             let framework =
-                seq {for outputType in this.Document |> getDescendants "TargetFrameworkVersion" ->
-                        outputType.InnerText }
-                |> Seq.map (fun s -> 
-                                let prefix = 
-                                    match this.GetTargetFrameworkIdentifier() with
-                                    | None -> "net"
-                                    | Some x -> x
-
-                                prefix + s.Replace("v","")
-                                |> FrameworkDetection.Extract)
-                |> Seq.map (fun o -> o.Value)
-                |> Seq.tryHead
+                try
+                    seq {for outputType in this.Document |> getDescendants "TargetFrameworkVersion" ->
+                            outputType.InnerText }
+                    |> Seq.map (fun s -> 
+                                    let prefix = 
+                                        match this.GetTargetFrameworkIdentifier() with
+                                        | None -> "net"
+                                        | Some x -> x
+
+                                    prefix + s.Replace("v","")
+                                    |> FrameworkDetection.Extract)
+                    |> Seq.map (fun o -> o.Value)
+                    |> Seq.tryHead
+                with
+                | _ -> None
 
             SinglePlatform(defaultArg framework (DotNetFramework(FrameworkVersion.V4)))