performance: don't recalculate array on each iteration in fuseConflicts

fsprojects · Apr 30, 2017 · 505c58c · 505c58c
1 parent f5deb48
commit 505c58c
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/Paket.Core/Dependencies/PackageResolver.fs b/src/Paket.Core/Dependencies/PackageResolver.fs
@@ -653,14 +653,15 @@ let Resolve (getVersionsF, getPackageDetailsF, groupName:GroupName, globalStrate
 
         let inline fuseConflicts currentConflict priorConflictSteps conflicts =
             let findMatchingStep priorConflictSteps =
+                let currentNames =
+                    conflicts
+                    |> Seq.collect (fun c ->
+                        let graphNameList =
+                            c.Graph |> List.map (fun (pr:PackageRequirement) -> pr.Name) 
+                        c.Name :: graphNameList)
+                    |> Seq.toArray
                 priorConflictSteps
                 |> List.tryExtractOne (fun (_,_,lastRequirement:PackageRequirement,_,_) ->
-                    let currentNames =
-                        conflicts |> Seq.collect (fun c ->
-                            let graphNameList =
-                                c.Graph |> List.map (fun (pr:PackageRequirement) -> pr.Name) 
-                            c.Name :: graphNameList)
-                        |> Seq.toArray
                     currentNames |> Array.contains lastRequirement.Name)
 
             match findMatchingStep priorConflictSteps with