Merge pull request #2407 from fsprojects/fix_2405

Paket failed with: String cannot be of zero length (#2405)

src/Paket.Core/PaketConfigFiles/InstallModel.fs

@@ -18,7 +18,8 @@ type FrameworkDependentFile = {
     Runtime : Rid option 
 }
 
-type Library = { 
+type Library = {
+    /// Usually the file name without extension, use for sorting and stuff.
     Name : string
     Path : string
     PathWithinPackage : string 
@@ -27,7 +28,11 @@ type Library = {
 module Library =
     let ofFile (f:FrameworkDependentFile) =
         let fi = FileInfo(normalizePath f.File.FullPath)
-        let name = fi.Name.Replace(fi.Extension, "")
+        // Extension can totally be an empty string, see https://github.com/fsprojects/Paket/issues/2405
+        let name =
+            let ext = fi.Extension
+            if String.IsNullOrEmpty ext then fi.Name
+            else fi.Name.Replace(ext, "")
         { Name = name; Path = f.File.FullPath; PathWithinPackage = f.File.PathWithinPackage }
 
 type RuntimeLibrary = { 

tests/Paket.Tests/InstallModel/ProcessingSpecs.fs

@@ -16,6 +16,16 @@ let fromLegacyList (prefix:string) l =
             { Paket.NuGet.UnparsedPackageFile.FullPath = i; Paket.NuGet.UnparsedPackageFile.PathWithinPackage = i.Substring(prefix.Length).Replace("\\", "/") }
         else failwithf "Expected '%s' to start with '%s'" i prefix)
 
+[<Test>]
+let ``Library.ofFile should not crash on files without extension``() =
+    let frameworkDepFile = {
+        Path = { Name = ""; Platforms= [] }
+        File =  { FullPath = Path.Combine(Path.GetTempPath(), "filewithoutext"); PathWithinPackage = "lib/net40" }
+        Runtime = None
+    }
+    let lib = Library.ofFile frameworkDepFile
+    lib.Name |> shouldEqual "filewithoutext"
+
 [<Test>]
 let ``should create empty model with net40, net45 ...``() = 
     let model = emptymodel.AddReferences ([ @"..\Rx-Main\lib\net40\Rx.dll"; @"..\Rx-Main\lib\net45\Rx.dll" ] |> fromLegacyList @"..\Rx-Main\")