PERFORMANCE: Use StringBuilder for path replacement - #487

fsprojects · Jan 1, 2015 · 2ff26c9 · mexx · Jan 6, 2015 · vasily-kirichenko
1 parent 6987cd8
commit 2ff26c9
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 24 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,3 +1,6 @@
+#### 0.20.11 - 01.01.2015
+* PERFORMANCE: Use StringBuilder for path replacement - https://github.com/fsprojects/Paket/issues/487
+
 #### 0.20.10 - 01.01.2015
 * PERFORMANCE: Cache feed errors - https://github.com/fsprojects/Paket/issues/487
 

diff --git a/src/Paket.Core/FrameworkHandling.fs b/src/Paket.Core/FrameworkHandling.fs
@@ -43,6 +43,31 @@ type FrameworkVersion =
           FrameworkVersion.V4_5_2
           FrameworkVersion.V4_5_3 ]
 
+module KnownAliases =
+    let Data =
+        [".net", "net"
+         "netframework", "net"
+         ".netframework", "net"
+         ".netcore", "netcore"
+         "winrt", "netcore"
+         "silverlight", "sl"
+         "windowsphone", "wp"
+         "windows", "win"
+         "windowsPhoneApp", "wpa"
+
+         "1.0", "10" 
+         "1.1", "11" 
+         "2.0", "20" 
+         "3.5", "35" 
+         "4.0", "40" 
+         "4.5", "45" 
+         "5.0", "50" 
+         "8.0", "80" 
+         "8.1", "81" 
+         "0.0", "" ]
+        |> List.map (fun (p,r) -> p.ToLower(),r.ToLower())
+
+
 /// Framework Identifier type.
 type FrameworkIdentifier = 
     | DotNetFramework of FrameworkVersion
@@ -55,31 +80,12 @@ type FrameworkIdentifier =
     | Silverlight of string
 
     static member Extract(path:string) =
-        let knownAliases =
-            [".net", "net"
-             "netframework", "net"
-             ".netframework", "net"
-             ".netcore", "netcore"
-             "winrt", "netcore"
-             "silverlight", "sl"
-             "windowsphone", "wp"
-             "windows", "win"
-             "windowsPhoneApp", "wpa"
-
-             "1.0", "10" 
-             "1.1", "11" 
-             "2.0", "20" 
-             "3.5", "35" 
-             "4.0", "40" 
-             "4.5", "45" 
-             "5.0", "50" 
-             "8.0", "80" 
-             "8.1", "81" 
-             "0.0", "" ]
-
+
         let path = 
-            knownAliases
-            |> List.fold (fun (path:string) (pattern,replacement) -> path.Replace(pattern.ToLower(),replacement.ToLower())) (path.ToLower())
+            let sb = new Text.StringBuilder(path.ToLower())
+            for pattern,replacement in KnownAliases.Data do
+                 sb.Replace(pattern,replacement) |> ignore
+            sb.ToString()
 
         match path with
         | "net10" | "net1" | "10" -> Some (DotNetFramework FrameworkVersion.V1)