Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type ahead does not work properly in Add package window #60

Closed
alexeyzimarev opened this issue Jun 14, 2015 · 5 comments · Fixed by fsprojects/Paket#1330
Closed

Type ahead does not work properly in Add package window #60

alexeyzimarev opened this issue Jun 14, 2015 · 5 comments · Fixed by fsprojects/Paket#1330

Comments

@alexeyzimarev
Copy link

When I use the Add package window, if I am fast and know the package name, I can type it in and see the right results. However, if I type slower, the throttle period is very little, so the list shows packages that match, say, first two letters. The problem is that any further input does not cause the list to refresh. Also, I can remove all text in the search box and enter something else, the list stays the same. The progress indicator is always on, never stops.

@forki
Copy link
Member

forki commented Jun 14, 2015

I mark this up-for-grabs since I think it would be a nice start for people to join the project.

@TheAngryByrd
Copy link
Contributor

I think this might be a problem upstream with the call into Paket.Core. Even though I added the OnComplete call, it still never seems to get the OnCompleted signal and the ReactiveCommand never properly "finishes". So this should be a good place to start looking.

@alexeyzimarev
Copy link
Author

First, we can increase the throttle to 500 ms instead of 250. Plus, add at least three characters condition in Where.

@alexeyzimarev
Copy link
Author

I am not an expert in ReactiveUI but I would have used CreateAsyncTask instead of CreateAsyncObservable.

@ForNeVeR
Copy link

Thank you guys for the clues. It seems that it's a problem with Paket.Utils.ObservableExtensions.flatten that never called obs.OnComplete. I'll send a PR to Paket core to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants