Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add example with global javascript import #224

Merged
merged 4 commits into from
Jun 26, 2019

Conversation

aprooks
Copy link
Contributor

@aprooks aprooks commented May 27, 2019

Added an example of using Util.LoadGlobalJavaScript to work with js libs, which won't work otherwise.

Also, please notice that when using this approach whole JS library is embedded in notebook and both Github and nbviewer fail to render cells with this import

@aprooks aprooks changed the title add example with global json load [WIP] add example with global json load May 27, 2019
@aprooks aprooks changed the title [WIP] add example with global json load [WIP] add example with global javascript May 27, 2019
@aprooks aprooks changed the title [WIP] add example with global javascript [WIP] add example with global javascript import May 27, 2019
@cgravill
Copy link
Member

cgravill commented Jun 7, 2019

Could you include the lines here as an example please? The full sized notebook is awkward for discussions.

@aprooks
Copy link
Contributor Author

aprooks commented Jun 12, 2019

this section is added right below D3 sample. Nothing else is changed.

image

@cgravill
Copy link
Member

Is this still current given discussion on #223 (comment)

I can see your solution being useful in some kind of advanced documentation. I similarly have some helpers that seem a bit involved for the main feature notebook but solves issues people might have.

@aprooks
Copy link
Contributor Author

aprooks commented Jun 26, 2019

No, these are only docs involving usage of Util.LoadGlobalJavascript. Not sure about advanced usage, but not being able to render some JS libs was almost the first issue I've stumbled upon when I tried to use IFsharp. Especially given I'm using it from docker and mac, and Angara and other plotting libs did not work for me.

Feel free to close though if you feel like it does not belong to main notebook.

@cgravill
Copy link
Member

Curious, Angara and XPlot both work for me on Mac but I'm not using Docker so perhaps there's an issue in there.

I'll go ahead and merge. There might need to be a future split of documents but for now the feature notebook is the place for everything to go in. Thanks for sharing.

@cgravill cgravill merged commit 5a415a7 into fsprojects:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants