-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for multi-target builds using Mono #119
Adding support for multi-target builds using Mono #119
Conversation
Removed target framework condition in .fsprojs Update FSharp.Core to 4.2.3 for netstandard2.0 Add explicit refs to System.Runtime and System.Reflection to make build pass.
Not sure what to do with MbUnit. I guess I could switch to new SDK for the project file and add the fix there to build on mono and just keep it on net45. |
Another thing, I had to add explicit references to System.Runtime and System.Reflection to get the build working, however I'm getting a lot of warnings about them not being found. Why do I have to add these? |
We could ignore According to |
Dependencies are strange, I thought that |
@atlemann this is beautiful! It works! |
Maybe we should just go back to what it was, since the page mentions that version: Does the FullFramework target have to be as late as net46? Could we also target net45 as mentioned in the link? I have been trying to find out why it needs System.Runtime and System.Reflection, but I cannot find any consistent answers and usually the fix seems to be to add an explicit reference. We might want add some assembly redirects, since I was getting a lot of warnings about "choosing version" etc. I can try to get rid of those warnings at least, before it's merged. |
I saw in Don Syme's comment that he also had to add references to some facade assemblies, so I guess that solution is fine. /home/atle/src/FsUnit/src/FsUnit.Xunit/FsUnit.fs(9,6): error FS1108: The type 'TypeInfo' is required here and is unavailable. You must add a reference to assembly 'System.Reflection, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. [/home/atle/src/FsUnit/src/FsUnit.Xunit/FsUnit.Xunit.fsproj] |
Looks like Travis CI lost its interwebs and Paket failed to download some deps. Other than that, I think I'm done. |
@atlemann Thank you! Definitely make sense to return to We could try Should we update |
If there were issues with < net46 then we should just keep it like it is now. Do we have to force reference facade assemblies for runtime? I'm no expert when it comes to those things. I can try to google it, or we could try to ask someone. |
Found some old threads about this. Looks like there shouldn't be an explicit reference in the NuGet package, but maybe we'll have to try to create a nuget locally and try to use it from a net46 and netcoreapp2.0 projects. aspnet/dnx#2031 |
I think that we are good for now and ready to merge. |
Fixes: #118