Set RollForward on FSharpLint.Console to latestMajor #704
Conversation
|
Hey @Numpsy thanks for the PR!
Can you please include all this great info in the commit message please? commit messages can have body, not just a title. Also, can you bring this to your PR: #687 (comment) This way we know for sure if the bug is fixed or not. |
refs fsprojects#687, whereby it appears to not be able to process .NET 7 or 8 projects when running on .NET 6, and always using the latest version seems to help. It looks like the current roll foward behaviour was added for fsprojects#519 to fix issues where only a newer version than the tool was built with is available, but this change would make it just use the latest all the time (so for example, if you have 6 and 8 installed, then it will use 8 all the time).
Upload binaries as artifact before pushing to nuget.
Add job that tests release binaries on Windows with .NET8.
|
I tried pulling in those other commits and the build failed with the error from #687 , but in the logs I saw Which looks like it was downloading the artifact for the test 0.24.3 build, but then installing the 0.24.2 build from NuGet. I've tried to fix that by adding |
|
Failure now looks like the |
|
Ok, so it now seems to be running the tool ok, but failing the build due to an error exit code, which is something i suppose:
|
|
Good progress Richard! But why would it throw this error here and not throw it in our SelfCheck CI step? |
|
A bit of testing locally suggests that there is some difference in behavior depending on if the FSharplint.Core project has been built before linting than if it hasn't (and the additional test step here isn't doing a build, just a restore as it stands). Possibly also related to the observation at #637 (comment) about different results when linting a single .fs file vs. doing the solution - If i run the 0.24.2 release against single files then I get the same warnings as the last CI build here got, whereas linting the built FSharplint.Core project has no warnings. |
Numpsy
changed the title
refs #687 , whereby it appears to not be able to process .NET 7 or 8 projects when running on .NET 6, and always using the latest version seems to help.
It looks like the current roll foward behaviour was added for #519 to fix issues where only a newer version than the tool was built with is available, but this change would make it just use the latest all the time (so for example, if you have 6 and 8 installed, then it will use 8 all the time).
I'm not sure if there is any potential to break anything that currently works though.