DRAFT: paket move to FAKE-only #680
Draft
Commits on Feb 12, 2024
-
Migrate from Paket to (Central Pkg Management)NuGet
CPM feature requires .NET 6.0.302 as explained in https://devblogs.microsoft.com/nuget/introducing-central-package-management/
-
Added ExcludeAssets="runtime" to Ms.Build.* nuget refs to fix build
Build error was: /home/runner/.nuget/packages/microsoft.build.locator/1.4.1/build/Microsoft.Build.Locator.targets(20,5): error : A PackageReference to Microsoft.Build.* without ExcludeAssets="runtime" exists in your project. This will cause MSBuild assemblies to be copied to your output directory, causing your application to load them at runtime. To use the copy of MSBuild registered by MSBuildLocator, set ExcludeAssets="runtime" on the MSBuild PackageReferences. To disable this check, set the property DisableMSBuildAssemblyCopyCheck=true in your project file (not recommended as you must distributed all of MSBuild + associated toolset). Package(s) referenced: Microsoft.Build.Tasks.Core;Microsoft.Build.Framework;Microsoft.Build.Utilities.Core;Microsoft.Build [/home/runner/work/FSharpLint/FSharpLint/src/FSharpLint.Core/FSharpLint.Core.fsproj]
-
Added nuget ref to Ms.Build.Locator to fix FNFE
To fix the following error in the build: System.IO.FileNotFoundException : Could not load file or assembly 'Microsoft.Build.Locator, Version=1.0.0.0, Culture=neutral, PublicKeyToken=9dff12846e04bfbd'. The system cannot find the file specified.
-
Update Ms.Build.Framework nuget to fix TLE
Easy solution to upgrade as recommended in dotnet/interactive#1985 (comment) The exception was: Could not load type 'Microsoft.Build.Framework.Traits' from assembly 'Microsoft.Build.Framework, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
-
Add NuGet.Frameworks nuget to try fix FLE
Exception was: System.IO.FileLoadException: Could not load file or assembly 'NuGet.Frameworks, Version=6.2.1.7, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Could not find or load a specific file. (0x80131621) File name: 'NuGet.Frameworks, Version=6.2.1.7, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
-
Replace NuGet.Frameworks nuget to workaround FLE
Previous commit adding the nuget reference didn't work. This is a workaround that works: dotnet/roslyn#61454 (comment)
-
Update Ms.Build.Tasks.Core nuget to fix MissingMethodEx
Exception was: Using "ResolveAssemblyReference" task from assembly "Microsoft.Build.Tasks.Core, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a". Task "ResolveAssemblyReference" The "ResolveAssemblyReference" task failed unexpectedly. System.MissingMethodException: Method not found: 'Void Microsoft.Build.Eventing.MSBuildEventSource.RarOverallStop()'.
-
-
WIP: remove references to Paket.Restore.targets
Rmove references to Paket.Restore.targets from .fsproj files as paket is no longer used.
-
WIP: upgrade somepackage versions
Upgraded FSC to 41.0.7,Ionide.ProjInfo. to 0.58, and FSharp.Core to 6.0.0 as these are versions used in current master branch.
-
-
FunctionalTest: removedworkaround
Removedworkaround from FunctionalTest.fsproj that caused error when building using Visual Studio.
-
WIP: revert Microsoft.Build version to 16.11
Revert Microsoft.Build and Microsoft.Build.Framework and Microsoft.Build.Utilities.Core versions to 16.11.
-
WIP: made some functional tests pass
Made changes to FSharpLint.FunctionalTest.fsproj and Directory.Packages.Props to avoid errors when loading projects in functional tests.
-
WIP: set System.Configuration.ConfigurationManager to version 6.0
In attempt to fix this error in functional tests: ``` "Could not load file or assembly 'System.Configuration.ConfigurationManager, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. Could not find or load a specific file. (0x80131621)")" ```
-
Add package references to fix `Could not load file or assembly ` bugs that prevented console app from working.
-
In Directory.Build.targets added PackageDownload deirectives for packages used by Fornax and a target that copies dlls from these downloaded packages to packages/docs directory as these are no longer managed by Paket. Package versions are exact because PackageDownload requires them to be exact.
-
- re-enable NU1605 warning; - fix package versions so there are no package downgrades which caused NU1605 errors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.