-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LintFile method to API layer #663
Draft
MrLuje
wants to merge
22
commits into
fsprojects:master
Choose a base branch
from
MrLuje:lint_layer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,293
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2023
ensure we can reuse an already found daemon version from another folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #637, so it should be merged first
See MrLuje/FSharpLint@9635b9a...MrLuje:FSharpLint:lint_layer diff for relevant changes
WIP on #627:
For reminder, the purpose of the API layer is to abstract away all FCS types so the caller can have a different FCS version than FSharpLint.
I duplicated types from https://github.com/fsprojects/FSharpLint/blob/master/src/FSharpLint.Core/Framework/Suggestion.fs to
FSharpLint.Client
and prefixed them withClient
(eg:SuggestedFix
=>ClientSuggestedFix
) to tell them apart. (I createdClientRange
from scratch to avoid the FCS dependency) but that's open to discussion.For now, the
LintFileRequest
takes the path to the file to lint and an optionalLintConfigPath
to afsharplint.json
file but I'm wondering about other scenario :defaultConfiguration
will be used (same with an invalidLintConfigPath
)fsharplint.json
is specified throughLintConfigPath
, it will be usedLintConfigPath
isn't specified but there is an existingfsharplint.json
in the project ? is there a standard location forfsharplint.json
or an existing detection method ? (next to solution file, parse [fc]sproj, etc)