formatting: wider lists #1444
Merged
formatting: wider lists #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
commented
Jun 2, 2022
| @@ -13,6 +13,7 @@ insert_final_newline = true | |||
| trim_trailing_whitespace = false | |||
|
|
|||
| [*.fs] | |||
| fsharp_max_array_or_list_width=80 | |||
There was a problem hiding this comment.
@nojaf It does feel to me that these defaults can be wider for F# code, likewise the other settings here
There was a problem hiding this comment.
I've opened fsprojects/fantomas#2288 to discuss this.
nojaf
reviewed
Jun 3, 2022
| @@ -13,6 +13,7 @@ insert_final_newline = true | |||
| trim_trailing_whitespace = false | |||
|
|
|||
| [*.fs] | |||
| fsharp_max_array_or_list_width=80 | |||
| fsharp_max_array_or_list_number_of_items=5 | |||
There was a problem hiding this comment.
fsharp_max_array_or_list_number_of_items does not do anything on its own.
You need to add fsharp_array_or_list_multiline_formatter=number_of_items for this to do anything. And please don't, I regress this setting exists in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the formatting settings