Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stack overflow when building debug code #1411

Merged
merged 2 commits into from
Nov 17, 2021
Merged

fix stack overflow when building debug code #1411

merged 2 commits into from
Nov 17, 2021

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Nov 17, 2021

Fixes #1410, a problem building the debug version of this repo with F# 6.

  1. It turns out Debug build of FSharp.Data.Tests was busted for a while with F# 5 because tailcalls weren't being taken during JSON parsing.
  2. When turning on explicit tailcalls for debug code, the problem went away with F# 5 but remains for F# 6 because of F# 6 takes fewer tailcalls in debug code when explicit /tailcalls+ is specified dotnet/fsharp#12413.
  3. The code changes workaround this

Also adds a debug build to the PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflows when compiling FSharp.Data.Tests in debug mode
1 participant