LHK-590 Added modern GraphQL Relay sample project with React #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andriilula please, review too |
|
@okhorsunenko-lula, @andriilula do we need |
|
@okhorsunenko-lula let's format fields = [
Define.Field("hasNextPage", Boolean, "When paginating forwards, are there more items?", fun _ pageInfo -> pageInfo.HasNextPage)
Define.Field("hasPreviousPage", Boolean, "When paginating backwards, are there more items?", fun _ pageInfo -> pageInfo.HasPreviousPage)
Define.Field("startCursor", Nullable String, "When paginating backwards, the cursor to continue.", fun _ pageInfo -> pageInfo.StartCursor)
Define.Field("endCursor", Nullable String, "When paginating forwards, the cursor to continue.", fun _ pageInfo -> pageInfo.EndCursor)
])or fields =
[ Define.Field("hasNextPage", Boolean, "When paginating forwards, are there more items?", fun _ pageInfo -> pageInfo.HasNextPage)
Define.Field("hasPreviousPage", Boolean, "When paginating backwards, are there more items?", fun _ pageInfo -> pageInfo.HasPreviousPage)
Define.Field("startCursor", Nullable String, "When paginating backwards, the cursor to continue.", fun _ pageInfo -> pageInfo.StartCursor)
Define.Field("endCursor", Nullable String, "When paginating forwards, the cursor to continue.", fun _ pageInfo -> pageInfo.EndCursor) ])What Fantomas will do? |
|
@okhorsunenko-lula so will you replace the old Relay folder content with content from the modern Relay? |
xperiandri
requested changes
Jan 20, 2023
There was a problem hiding this comment.
@okhorsunenko-lula, looks good!
Fixing a few comments and a workflow update left
okhorsunenko-lula
force-pushed
the
LHK-590-implement-graphql-relay-cursor
branch
2 times, most recently
from
68f05dc to
b9e3efd
Compare
xperiandri
requested changes
Jan 23, 2023
xperiandri
force-pushed
the
LHK-590-implement-graphql-relay-cursor
branch
2 times, most recently
from
ea82c58 to
7d7e265
Compare
xperiandri
force-pushed
the
LHK-590-implement-graphql-relay-cursor
branch
from
7d7e265 to
75022b9
Compare
|
@okhorsunenko-lula test Relay again. I made |
xperiandri
requested changes
Jan 27, 2023
|
@okhorsunenko-lula we need to test the sample manually again. Then we can merge |
|
@xperiandri tested, looks good and works, attaching the screenshot
|
xperiandri
force-pushed
the
LHK-590-implement-graphql-relay-cursor
branch
from
7daca9f to
ca221a8
Compare
xperiandri
approved these changes
Feb 4, 2023
xperiandri
changed the title
xperiandri
pushed a commit
to Lula-Archive/FSharp.Data.GraphQL
that referenced
this pull request
Aug 7, 2023
…cts#420) Co-authored-by: Andrii Chebukin <[email protected]>
xperiandri
pushed a commit
to Lula-Archive/FSharp.Data.GraphQL
that referenced
this pull request
Aug 7, 2023
…cts#420) Co-authored-by: Andrii Chebukin <[email protected]>
xperiandri
pushed a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Andrii Chebukin <[email protected]>
xperiandri
pushed a commit
to Lula-Archive/FSharp.Data.GraphQL
that referenced
this pull request
Aug 10, 2023
…cts#420) Co-authored-by: Andrii Chebukin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.