Add implementation of TaskSeq.except/exceptOfSeq #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the following, in line with
Seq.except
. I'm considering adding aTaskSeq.remove
, as it'd be a much lighter implementation and users may not always need set-except operation style.This adds:
@dsyme I'm not 100% sure this r/w lock approach is ideal (as I have to use it synchronously), I'm considering either a semaphore or adding an F# version of Stephen Cleary's
AsyncReaderWriterLock
(itself based on Stephen Toub's) implementation, which may be useful to expose as well somehow.A similar comment about using a r/w lock was mentioned in some spots in
AsyncSeq
.https://github.com/StephenCleary/AsyncEx/blob/8a73d0467d40ca41f9f9cf827c7a35702243abb8/src/Nito.AsyncEx.Coordination/AsyncReaderWriterLock.cs#L16