Improve GetAsyncEnumerator, move inheritance of IAsyncDisposable #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the struggle with #42, some cleanup is needed, and some refactoring. Also, a few functional changes:
IAsyncEnumerable
itself should not implementIAsyncDisposable
, instead, onlyIAsyncEnumerator
should implement that, by default, because it already inherits from that interface. This change prevents accidentaluse x = myTaskSeq
code, which we really should prevent.Note: it is unlikely this would happen in practice, as we strictly return
IAsyncEnumerable<'T>
, however, someone creative could cast and succeed. Plus, it just doesn't make sense in the current implementation.GetAsyncEnumerator()
. Only initializeTaskSeqStateMachineData
when needed. That means, we won't initialize it anymore directly in theAfterCode<_, _>
section.InitEnumerator
function, as after the previous change, we'll need to initialize fromReturnFrom
as well, asData
member can now benull
.