Cleanup: Spelling, unused bindings #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bartelink
commented
Dec 24, 2023
abelbraaksma
force-pushed
the
spelling-tidying
branch
from
8bc40da to
bfb6938
Compare
abelbraaksma
requested changes
Dec 24, 2023
There was a problem hiding this comment.
Completed the review. Most of these changes are excellent and I totally agree with them, some I don't, so I suggested to revert them.
I'll commit the changes and squash some of the commits.
Excellent work, btw! In VS, it stopped showing these warnings a while ago, another thing to fix in the F# IDE extensions.
abelbraaksma
added
refactoring
abelbraaksma
force-pushed
the
spelling-tidying
branch
from
aa16e6a to
d21c5c2
Compare
abelbraaksma
approved these changes
Dec 24, 2023
abelbraaksma
force-pushed
the
spelling-tidying
branch
from
078d604 to
42c9ad3
Compare
|
Cleaned up the commit history, this is now good to go. Thanks for this, @bartelink, much appreciated!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edit by @abelbraaksma):
This:
use _ = ...syntax, which is now supported by F#