Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fantomas rules and require CI to pass Fantoma formatting #182

Merged
merged 7 commits into from
Oct 29, 2023

Conversation

abelbraaksma
Copy link
Member

@abelbraaksma abelbraaksma commented Oct 29, 2023

This updates the Fantomas rules w.r.t. to the Stroustrup formatting, which is not an experimental feature anymore, and now has changed the necessary config properties for the latest Fantomas versions.

This will require dotnet fantomas . to be run after non-formatted changes have been made.

@abelbraaksma
Copy link
Member Author

There you go:
image

@abelbraaksma
Copy link
Member Author

All done an dusted and green again. Merge time :). To any prospective committers, run this:

# run restore once
dotnet tool restore 

# run before you commit your changes
dotnet fantomas .

@abelbraaksma abelbraaksma merged commit 850c36f into main Oct 29, 2023
6 checks passed
@abelbraaksma abelbraaksma deleted the fix-and-ci-require-fantomas-formatting-rules branch October 29, 2023 16:13
@abelbraaksma abelbraaksma added github_actions Pull requests that update GitHub Actions code refactoring Cleanup, refactoring and minor fixes build and infra Related to building or infrastructure labels Oct 29, 2023
@abelbraaksma abelbraaksma added this to the v0.4.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build and infra Related to building or infrastructure github_actions Pull requests that update GitHub Actions code refactoring Cleanup, refactoring and minor fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant