Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancellation support (experimental!) #132

Closed
wants to merge 2 commits into from

Conversation

abelbraaksma
Copy link
Member

Following up on #114, and specially @gusty's suggestion (#114 (comment)), this is another attempt to making that work.


So, I gave it another try. It appears that the problem is that, when you have "automatic" methods (bind, yield, return, zero), the compiler wants a For implementation whenever you add a custom operation.

Now, there already is a For implementation, of course. Probably, the signature should be different. I don't know how this would desugar. Here's a screenshot of the error.

image

@abelbraaksma abelbraaksma self-assigned this Dec 18, 2022
@abelbraaksma abelbraaksma added enhancement New feature or request topic: taskseq-ce Related to the taskseq computation expression builders or overloads labels Dec 18, 2022
@abelbraaksma abelbraaksma marked this pull request as draft December 18, 2022 02:05
@abelbraaksma abelbraaksma force-pushed the add-cancellation-support branch from 9bd1f49 to 145a840 Compare October 29, 2023 18:56
@abelbraaksma abelbraaksma force-pushed the add-cancellation-support branch from 145a840 to 87f24aa Compare October 29, 2023 18:58
@abelbraaksma
Copy link
Member Author

Closing this, see further experiments in #197.

@abelbraaksma abelbraaksma deleted the add-cancellation-support branch November 5, 2023 16:32
@abelbraaksma abelbraaksma modified the milestones: v0.4.0-alpha.1, v0.4.0 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: taskseq-ce Related to the taskseq computation expression builders or overloads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant