Test wrongly successful build steps in CI #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelbraaksma
force-pushed
the
test-wrongly-successful-workflow
branch
from
2a02922 to
e50455f
Compare
abelbraaksma
force-pushed
the
test-wrongly-successful-workflow
branch
from
e50455f to
1b6dc76
Compare
abelbraaksma
added
github_actions
abelbraaksma
added a commit
that referenced
this pull request
Mar 17, 2024
abelbraaksma
added a commit
that referenced
this pull request
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that the CI steps incorrectly returns
success. Runningbuild.cmdin a default CI Github workflow leads to the%ERRORLEVEL%being swallowed, which is a result of the default shell on Windows being PowerShell Core. See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell for more info.Solution: use
shell: cmdin the steps that require proper handling of Windows command scripts.Also, see this SO question.
Before rewriting the history in this PR, there were numerous attempts at fixing this, using a deliberately failing (compile error) build, which kept showing up as green (success). Squashed all those bits for readability.