Skip to content

Commit

Permalink
Downgrade FSharp.Core to the lowest denominator from our main project…
Browse files Browse the repository at this point in the history
…: 6.0.1: achieve best backward compat testing

We want to remove the dependency in our tests on FsToolkit.ErrorHandling.TaskResult in PR #181 because it uses a high version of FSharp.Core. In other words, it disallows us to properly test TaskSeq with the lowest-denominator FSharp.Core it was compiled with, which we should do, to ensure stability in the widest range of forward-and-backward compatibility. The SmokeTests library, on the other hand, uses the highest RTM release of FSharp.Core and we don't really care about other deps there.
  • Loading branch information
abelbraaksma committed Oct 28, 2023
1 parent 51a16c6 commit 0def05a
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<ItemGroup>
<!-- align test project with minimal required version for TaskSeq -->
<!-- we use 6.0.3 here and not 6.0.2 because TaskResult lib requires it-->
<PackageReference Update="FSharp.Core" Version="6.0.3" />
<PackageReference Update="FSharp.Core" Version="6.0.1" />
<PackageReference Include="FsUnit.xUnit" Version="5.5.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageReference Include="xunit" Version="2.5.3" />
Expand Down

0 comments on commit 0def05a

Please sign in to comment.