Better unknow target handling & build.cmd #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.cmd wasn't using SETLOCAL but was using SET on an environment variable named 'TARGET' that was leaking out of the script. The 'TARGET' variable was also adding needless quotes to the name of the target (That were later trimed due to argument processing but still needless)
The dictionary of targets was sometimes acceded directly and was throwing KeyNotFoundException. The getTarget helper is now used everywhere, providing the name of the invalid target and also printing the list of valid target on the console.
Both of the following invocations are now equivalent
build.cmd Test
build.cmd "Test"
|
thx |
forki
added a commit
that referenced
this pull request
Sep 22, 2015
Better unknow target handling & build.cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TLDR:
SETLOCALinbuild.cmdto ensure that it doesn't touch the global environmentbuild.cmdhandle build target names quoted or not as first arggetTargetfunction that provide an nice error display.Why
I had a problem today where FAKE wasn't building some of our projects anymore, after searching the real reason was that I built fake in the same terminal a little bit before and that
build.cmdset the environment variableTARGETto"Default"(With the quotes).The problem with that is that while FAKE
build.cmdpass it on the command line, and the extra quotes are removed from there our own build script doesn't and just call :(The fact that we also use a task named
Defaultmade that a lot harder to debug, took me time to understand who set this evironment variable)But
RunTargetOrDefaultwill also use an environment variableTARGETif it exists, except that it doesn't trim quotes :DAnd then fake was failing with the not really helpful :