Add date to ReleaseNotes type definition #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a parser to handle looking for dates in the header of complex-formatted release notes.
Currently failing because the date "2013/11/5" isn't being caught by the regular expression being used.
|
very nice. |
forki
added a commit
that referenced
this pull request
Aug 24, 2015
Add date to ReleaseNotes type definition
forki
added a commit
that referenced
this pull request
Aug 24, 2015
|
Sorry, should have thought to include a backwards-compatible constructor. Thanks for cleaning up after me 😬 |
|
No worries. I'm breaking things in FAKE for over 5 years now ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new "Date" field as a
DateTime optionto theReleaseNotesrecord type, and performs simple parsing of dates from the complex release notes format. The regex I used finds dates in the format ofYYYY-MM-DD, with the option to use any of- /.as the separators, but I pass the matched result toDateTime.TryParse. Should be able to change the regex (or add additional regexes) to match other date formats, but really, who doesn't use ISO-8601? 😉