-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat non csproj files as nuspec files #767
Treat non csproj files as nuspec files #767
Conversation
I'd like to accept this change, but I assume yoo need to consider vb, F# and other project types. Question: why don't you go with the nuget default? |
@forki Look at the change. It's just reversing the defaults. @MaximilianLackaw did not care about whatsoever project files are going to be supported. I think it was @jamescrowley only going for |
I was talking about https://github.com/fsharp/FAKE/pull/767/files#diff-88b397b8b3d4d92a120c4eb5fce2b2d5R236 it introduces the new constant "csproj". |
…all .net proj files
nice. |
I was talking about that as well. Maybe I can't read F#, but the match expression reads to me "If file ends with csproj, please do some magic, otherwise treat it as a nuspec template file". Isn't this exactly what #644 was attempting to but went for the inverted logic "if it ends with nuspec, then treat it as a nuspec template file, otherwise do some magic". |
So @MaximilianLackaw fixed it anyway. Forget about my nitpicking. |
yep. but my point was: we should do the magic for all project types. |
…as-nuspec-files Treat non csproj files as nuspec files
Just out of curiosity: why don't you go for *.nuspec? |
Well you know it might be that template files are going to be packaged within nugets but may not be suffixed |
Currently nuspec files must have a .nuspec file extension to be treated as valid nuspec templates. We have nuspec files without this extension which no longer work with up to date versions. The only reason why this distinction exists, is to cover .csproj files. So our suggestion is to just look for the .csproj file extension.