Added frameworkAssemblies to nuspec templating #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
khellang
commented
Mar 31, 2015
khellang
commented
| @@ -19,6 +19,10 @@ type NugetFrameworkReferences = | |||
| { FrameworkVersion : string | |||
| References : NugetReferences } | |||
|
|
|||
| type NugetFrameworkAssemblyReferences = | |||
There was a problem hiding this comment.
I guess I could've reused the existing NugetFrameworkReferences type and grouped framework assembly references on FrameworkVersion instead. What do you think?
There was a problem hiding this comment.
I think it's ok to have both types. We also separate these in paket.
There was a problem hiding this comment.
I wonder if we should make the FrameworkVersion a string list
|
thanks. only one small issue. |
khellang
force-pushed
the
framework-assemblies-nuspec
branch
from
e2b5834 to
e23df9d
Compare
forki
added a commit
that referenced
this pull request
Mar 31, 2015
Added frameworkAssemblies to nuspec templating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.