Added metadata string property for AssemblyInfoReplacementParams

[jchannon]

Added metadata string property for AssemblyInfoReplacementParams

[forki]

You added a parameter but I can't see where you are using it.

[forki]

Ah now I see. Lgtm. The only issue is I'm on vacation so I can only merge it Monday

[forki]

And you still need to give the default parameter a value.

[forki]

Ok the error now is only related to github Api limits

[jchannon]

Actually this might need to be an array rather than a string looking at the screenshot here http://fsharp.github.io/FAKE/assemblyinfo.html

[forki]

That thing from the Screenshot is a different api
On Mar 6, 2015 7:09 PM, "Jonathan Channon" [email protected] wrote:

Actually this might need to be an array rather than a string looking at
the screenshot here http://fsharp.github.io/FAKE/assemblyinfo.html

—
Reply to this email directly or view it on GitHub
#675 (comment).

[jchannon]

But Metadata needs to populate multiple values? eg "gitcommit","23445fs"

[forki]

Ah that's what you mean.
On Mar 6, 2015 7:15 PM, "Jonathan Channon" [email protected] wrote:

But Metadata needs to populate multiple values? eg "gitcommit","23445fs"

—
Reply to this email directly or view it on GitHub
#675 (comment).

[jchannon]

guess I could just do the below for now

fun f -> 
            {f with 
                  AssemblyVersion = fullBuildNumber
                  AssemblyInformationalVersion = fullBuildNumber
                  AssemblyMetadata = "\"githash\"" + "," + "\"6868767gf\""
                  })

[forki]

I'd prefer to have it an array instead
On Mar 6, 2015 7:22 PM, "Jonathan Channon" [email protected] wrote:

guess I could just do the below for now

fun f ->
{f with
AssemblyVersion = fullBuildNumber
AssemblyInformationalVersion = fullBuildNumber
AssemblyMetadata = ""githash"" + "," + ""6868767gf""
})

—
Reply to this email directly or view it on GitHub
#675 (comment).

[jchannon]

Probably best you add that, I've spent the last couple of hours trying to get it to work and failed 😄

[forki]

Will do
On Mar 7, 2015 2:57 PM, "Jonathan Channon" [email protected] wrote:

Probably best you add that, I've spent the last couple of hours trying to
get it to work and failed [image: 😄]

—
Reply to this email directly or view it on GitHub
#675 (comment).

[forki]

65338a7 - is this what you meant?

[jchannon]

Yup I tried with a seq and a string concat but couldn't get it to work!

Nice work. Will pull the latest version tomorrow :)

On Sunday, 8 March 2015, Steffen Forkmann [email protected] wrote:

65338a7
65338a7

• is this what you meant?

Reply to this email directly or view it on GitHub
#675 (comment).