Change RemoveDuplicateFiles & FixMissingFiles to only save on change

[bentayloruk]

RemoveDuplicateFiles & FixMissingFiles overwrite the existing project file, even when there are no changes. If an editor is open, the change in the file modified attribute, triggers a reload. This PR changes the functions to only write when changes are detected.

This is the simplest fix I could make and is not tested. I'll tidy up if you are OK with this in principle.

[forki]

I like the idea. "approved in principle" as @dsyme would say. ;-)
On Jul 12, 2014 12:04 AM, "Ben Taylor" [email protected] wrote:

RemoveDuplicateFiles & FixMissingFiles overwrite the existing project
file, even when there are no changes. If an editor is open, the change in
the file modified attribute, triggers a reload. This PR changes the
function to only write when changes are detected.

*This is the simplest fix I could make and is not tested. I'll tidy up if

you are OK with this in principle.*

You can merge this Pull Request by running

git pull https://github.com/bentayloruk/FAKE fixprojectfiles-no-op

Or view, comment on, or merge it at:

#499
Commit Summary

• Change RemoveDuplicateFiles and FixMissingFiles to save the their
  newProject instances only when there are actually changes (prevents project
  file modified datetime change and reload in editor).

File Changes

• M src/app/FakeLib/MSBuild/ProjectSystem.fs
  https://github.com/fsharp/FAKE/pull/499/files#diff-0 (10)

Patch Links:

• https://github.com/fsharp/FAKE/pull/499.patch
• https://github.com/fsharp/FAKE/pull/499.diff

—
Reply to this email directly or view it on GitHub
#499.

[bentayloruk]

Sweet! I never even had to do the "tidy up" :)