Core.Process: only set StandardEncoding if output/err is redirected #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yazeedobaid I guess it was you who whitelisted me so that CI could run in this PR? I believe the macOS lane is not broken by my PR but because of a different issue which I filed here: #2671 |
|
@knocte yes I approved the CI run. For first-time contributors, the CI needs admin approval. |
|
Hi thanks for the PR |
Should potentially fix fsprojects#2670
knocte
force-pushed
the
net472ProcessEncodingFix
branch
from
c611585 to
67f896e
Compare
Done. |
|
Thanks for the fix, can u please try to add tests to it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should potentially fix #2670