Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting Bitbucket module to FAKE 5 #2583

Merged

Conversation

yazeedobaid
Copy link
Collaborator

Description

This PR ports the Bitbucket pipeline module to FAKE 5. The module contains helper methods to get Bitbucket pipeline environment variables which are set by pipeline during a build.

TODO

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)
  • unit or integration test exists (or short reasoning why it doesn't make sense)
  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.
  • (if new module) the module is in the correct namespace
  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)
  • Fake 5 API guideline is honored

@yazeedobaid yazeedobaid force-pushed the port-bitbucket-module branch from 3fd4f23 to 00aec32 Compare April 5, 2021 10:28
@matthid
Copy link
Member

matthid commented Apr 5, 2021

Thanks :)

@matthid matthid merged commit 3962129 into fsprojects:release/next Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants