Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a wrong decoration #2502

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix a wrong decoration #2502

merged 1 commit into from
Apr 23, 2020

Conversation

objectx
Copy link
Contributor

@objectx objectx commented Apr 19, 2020

Description

--single-target should be included inside of `…`

TODO

This is a trivial documentation fix. No behaviors should be changed.

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.

  • (if new module) the module is in the correct namespace

  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake 5 API guideline is honored

Should be included inside of \`\`
@matthid
Copy link
Member

matthid commented Apr 23, 2020

Yep, thanks!

@matthid matthid merged commit a6120ff into fsprojects:release/next Apr 23, 2020
@objectx
Copy link
Contributor Author

objectx commented Apr 23, 2020

I've just found a typo in Running targets in "FAKE - F# Make"

isntead → instead

@objectx objectx deleted the patch-1 branch April 23, 2020 12:14
@matthid
Copy link
Member

matthid commented Apr 23, 2020

Thanks, fixed in ae35979

@matthid matthid mentioned this pull request May 4, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants