Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the README badges and their placement. #2437

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Change the README badges and their placement. #2437

merged 1 commit into from
Dec 11, 2019

Conversation

teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented Dec 11, 2019

GitLab CI and CircleCI are not maintained (the first at least is not visible).

AppVeyor's badge image link needs to be updated.

GitLab CI and CircleCI are not maintained (the first at least is not visible).

AppVeyor's badge image link needs to be updated.
@matthid
Copy link
Member

matthid commented Dec 11, 2019

Probably fair, while gitlab is still in use it is not publically visible for some reason (I just looked at it: There doesn't seem to be any setting for it. I always have to log in to see the build). CirlcleCI indeed stopped working and I never cared to much to enable it again I guess :)

@matthid matthid merged commit 51dfe7c into fsprojects:release/next Dec 11, 2019
@teo-tsirpanis
Copy link
Contributor Author

You have to update the link for AppVeyor's badge image; it still points to the old one, where the build is successful. Because it seemed to be private, I couldn't do it myself.

@matthid matthid mentioned this pull request Dec 14, 2019
@matthid
Copy link
Member

matthid commented Dec 17, 2019

@teo-tsirpanis Can you repeat what exactly is still missing with the AppVeyor badge? Currently it seems to be OK:

image

@teo-tsirpanis
Copy link
Contributor Author

It is the badge's picture. It always says "BUILD PASSING" even when it was failing in the past, because it still using the old project.

You have to get the new URL from AppVeyor's settings:

AppVeyor's settings pane

@matthid
Copy link
Member

matthid commented Dec 17, 2019

@teo-tsirpanis Thanks for the fast response. I think I got it sorted out...

@teo-tsirpanis teo-tsirpanis deleted the patch-2 branch December 25, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants