Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress copyright messages when invoking dotnet build #2436

Merged

Conversation

objectx
Copy link
Contributor

@objectx objectx commented Dec 11, 2019

Description

Suppress copyright messages when invoking dotnet build.

Currently, there is no easy way to do that.

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
    /Fake.*.fsproj`)

  • Fake 5 API guideline is honored

@matthid
Copy link
Member

matthid commented Dec 11, 2019

In fact, I'm pretty sure the failure is not related to this change. If not you got lucky on your first PR :)
Thanks for taking care of this!

@matthid matthid merged commit 1f4d010 into fsprojects:release/next Dec 11, 2019
@objectx
Copy link
Contributor Author

objectx commented Dec 12, 2019

🙇

I've also found that DotNet.fs contains many of trailing spaces. At this PR, I intentionally exclude those to minimize diffs.

@objectx objectx deleted the feature/dotnet-build-nologo branch December 12, 2019 00:46
@matthid matthid mentioned this pull request Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants