Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the extra OpenCover registration options (for skipping COM regist… #2387

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

SteveGilham
Copy link
Contributor

Description

TODO

  • unit or integration test exists (or short reasoning why it doesn't make sense)

As there are currently none for the module, the change by itself is a minimal increment of technical debt.

…ration and loading by relative file path instead)
@matthid
Copy link
Member

matthid commented Aug 26, 2019

Thanks!

As there are currently none for the module, the change by itself is a minimal increment of technical debt.

Indeed, it's just good to have the infrastructure in place when an actual bugfix is required. I tried to increase the quality bar (no bugfix / changes on "old" modules without these changes). So this indeed needs a test and ideally use the properly escaping APIs. I can take care of this but it will take a couple of days.

@matthid matthid added the needs-tests This PR needs tests in order to be accepted label Aug 26, 2019
@matthid matthid mentioned this pull request Oct 12, 2019
@matthid matthid merged commit 52f8194 into fsprojects:master Oct 12, 2019
@SteveGilham SteveGilham deleted the develop/issue-2386 branch October 18, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs tests in order to be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants