Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SelfContained, Force and Manifest to dotnet publish, #2307

Merged
merged 2 commits into from
Apr 28, 2019

Conversation

gdziadkiewicz
Copy link
Contributor

@gdziadkiewicz gdziadkiewicz commented Apr 26, 2019

Description

Dotnet publish parameters lacked self-contained param. Without it it is not possible to do publish for specific runtime without embedding the runtime. While editing it I have added two other missing params - force and manifest.

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.

  • (if new module) the module is in the correct namespace

  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake 5 API guideline is honored

@matthid matthid changed the base branch from master to release/next April 26, 2019 21:19
@matthid
Copy link
Member

matthid commented Apr 26, 2019

Thanks a lot for taking care of this! Looks good to me, any reason for it to be a draft?

@gdziadkiewicz gdziadkiewicz marked this pull request as ready for review April 28, 2019 10:50
@gdziadkiewicz
Copy link
Contributor Author

I have added missing tests and updated the manifest parameter description. Now it should be good to go.

@matthid matthid merged commit b7dd1f1 into fsprojects:release/next Apr 28, 2019
@gdziadkiewicz gdziadkiewicz deleted the AddSelfContained branch April 28, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants