Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet Push command syntax. Fixes #2299 #2304

Merged

Conversation

aklefdal
Copy link
Contributor

Description

  • Creating NuGet push arguments that are right when it comes to quotes ("). This code is based upon similar code that for some reason exists in Fake.Dotnet.Cli.
  • Generate Timeout argument in seconds
  • Fixes issue Invalid syntax of NuGet push after 5.13.0 #2299

TODO

How to test it in a real project?

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)
  • unit or integration test exists (or short reasoning why it doesn't make sense)
  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
  • [-] (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.
  • [-] (if new module) the module is in the correct namespace
  • [-] (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)
  • [-] Fake 5 API guideline is honored

@matthid matthid changed the base branch from master to release/next April 26, 2019 16:04
@matthid
Copy link
Member

matthid commented Apr 26, 2019

Thanks a lot, looks good!

This code is based upon similar code that for some reason exists in Fake.Dotnet.Cli.

Indeed but we can fix that later, hopefully. This fixes a bug and looks good.

@matthid matthid merged commit 300fe0b into fsprojects:release/next Apr 26, 2019
@atlemann
Copy link
Contributor

That was fast. Was just about to fix my own mistake.

The reason for duplicating those argument builders is that nuget.exe push requires PascalCase while dotnet nuget push requires kebab-case. So I wasn't able to share any code but the arguments record, unfortunately.

@matthid matthid mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants