Add support for MSBuild 16 / VS 2019 #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS2019 changes the location of MSBuild from e.g. MSBuild\15.0\Bin to MSBuild\Current\Bin. This changes the approach to search all folders within MSBuild for Bin\MSBuild.exe and reads the major version from the executable itself.
vbfox
reviewed
Mar 15, 2019
vbfox
approved these changes
Mar 16, 2019
|
Ok, thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS2019 changes the location of MSBuild from e.g.
MSBuild\15.0\BintoMSBuild\Current\Bin. This is noted in the VSWhere Wiki:This changes the approach to search all folders within MSBuild for
Bin\MSBuild.exeand reads the major version from the executable itself.The fix is as suggested by @vbfox in a comment to the issue. I've tested on my machine with only VS 2019 RC installed, MSBuild 16 is now picked instead of MSBuild 14.
Fixes #2271