Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed getBaseDirectoryInclude when one directory name include the oth… #2235

Merged
merged 2 commits into from
Feb 2, 2019
Merged

Fixed getBaseDirectoryInclude when one directory name include the oth… #2235

merged 2 commits into from
Feb 2, 2019

Conversation

humhei
Copy link
Contributor

@humhei humhei commented Jan 14, 2019

Fixes #2230

@humhei
Copy link
Contributor Author

humhei commented Jan 14, 2019

I don't know why CI sucessed in windows but failed in linux

@matthid
Copy link
Member

matthid commented Jan 14, 2019

Maybe the change has broken something on unix (note that on unix path separator is / not )
I can take a look but it will take a couple of days.

It might also be that the existing test has a bug?

@matthid
Copy link
Member

matthid commented Feb 2, 2019

Huh, it looks like it worked, thanks for the fix and the test!

@matthid matthid merged commit 0339803 into fsprojects:release/next Feb 2, 2019
@matthid matthid mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humhei @matthid