Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor overlapping with text above in #2207 #2209

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

sliepie
Copy link
Contributor

@sliepie sliepie commented Nov 19, 2018

PR for solution provided in #2202

@florianbader
Copy link
Contributor

florianbader commented Nov 19, 2018

Looks good to me. I would increase the height and margin to 70px to have a bit more space between the navigation and the text like we had before.

@sliepie
Copy link
Contributor Author

sliepie commented Nov 19, 2018

At first when trying this out I started with 70px for the height and margin. After fiddling I learned that the heigt/margin must be the same as the top navbar. Because that's the extra space that the content must be pushed down.

Image with height/margin of 50px
image

And one with 70px
image

@matthid matthid merged commit 9b92947 into fsprojects:release/next Nov 19, 2018
@matthid
Copy link
Member

matthid commented Nov 19, 2018

@JarnoNijboer Thanks a lot for this detail work!

@baronfel
Copy link
Contributor

Thanks y'all for finding the proper fix here

@matthid matthid mentioned this pull request Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor top-padding breaks user interaction
4 participants