Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the obvious Windows-only tools fail explicitly off the supported platform #2200

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

SteveGilham
Copy link
Contributor

Description

Fixes #2199, as per discussion on previous PR, to make behaviour consistent with the expressed intention across both the obviously Windows-only tools I recently PR'd

TODO

I believe the checklist to be complete

…s fail explicitly off the supported platform
@SteveGilham
Copy link
Contributor Author

Circle-CI failure was in an un-touched piece of the code

Ignored:   0
Failed:    0
Errored:   1
	Fake.Core.Globbing.Tools.Tests/Test find tool folder in sub path <Expecto>

presumably related to an earlier exception message

System.IO.DirectoryNotFoundException: Could not find a part of the path '/build/some path'.
   at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)
   at System.IO.Enumeration.FileSystemEnumerator`1..ctor(String directory, EnumerationOptions options)
   at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options)
   at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options)
   at System.IO.Directory.InternalEnumeratePaths(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
   at [email protected](String dir) in /build/src/app/Fake.IO.FileSystem/Globbing.fs:line 53
   at Microsoft.FSharp.Primitives.Basics.List.collectToFreshConsTail[T,TResult](FSharpFunc`2 f, FSharpList`1 list, FSharpList`1 cons)
   at Microsoft.FSharp.Primitives.Basics.List.collect[T,TResult](FSharpFunc`2 f, FSharpList`1 list)
   at Fake.IO.Globbing.Glob.search(String baseDir, String originalInput) in /build/src/app/Fake.IO.FileSystem/Globbing.fs:line 133
   at <StartupCode$Fake-IO-FileSystem>.$GlobbingFileSystem.System-Collections-Generic-IEnumerable-1-GetEnumerator@39-2.GenerateNext(IEnumerable`1& next) in /build/src/app/Fake.IO.FileSystem/GlobbingFileSystem.fs:line 40
   at Microsoft.FSharp.Core.CompilerServices.GeneratedSequenceBase`1.MoveNextImpl()
   at Microsoft.FSharp.Collections.Internal.IEnumerator.next@187[T](FSharpFunc`2 f, IEnumerator`1 e, FSharpRef`1 started, Unit unitVar0)
   at Microsoft.FSharp.Collections.Internal.IEnumerator.next@187[T](FSharpFunc`2 f, IEnumerator`1 e, FSharpRef`1 started, Unit unitVar0)
   at Microsoft.FSharp.Collections.SeqModule.TryHead[T](IEnumerable`1 source)
   at Fake.IO.Globbing.Tools.tryFindToolFolderInSubPath(String toolname) in /build/src/app/Fake.IO.FileSystem/GlobbingFileSystem.fs:line 246
   at [email protected](Unit _arg3) in /build/src/test/Fake.Core.UnitTests/Fake.IO.Globbing.fs:line 99
   at [email protected](Unit unitVar) in C:\Users\Anthony Lloyd\src\expecto\Expecto\Expecto.fs:line 929
   at [email protected](AsyncParams`1 args)

@matthid
Copy link
Member

matthid commented Nov 15, 2018

Yes interesting I was just looking at the same thing. I guess we would open an issue for this exception and I'll click the retry button

Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this :)

@matthid matthid merged commit f5788ed into fsprojects:release/next Nov 18, 2018
@matthid matthid mentioned this pull request Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants