Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TeamCity Improvements #2138

Merged
merged 4 commits into from
Oct 11, 2018
Merged

TeamCity Improvements #2138

merged 4 commits into from
Oct 11, 2018

Conversation

BlythMeister
Copy link
Contributor

Description

  • Correcting TeamCity publish named artifacts
  • Add report build problems
  • Tidy TeamCity listener
  • Extract all messages into TeamCityInternal (which is internal...as the name suggests) and called by TeamCity (which is public). Added advantage is that messages can be used in many ways by different public methods. Also, the messages suddenly become strongly typed(ish)

@BlythMeister BlythMeister mentioned this pull request Oct 10, 2018
Merged
@BlythMeister BlythMeister mentioned this pull request Oct 10, 2018
Merged
@matthid
Copy link
Member

matthid commented Oct 10, 2018

Hm, I tried to merge in latest release/next changes into this PR and now apparently github cannot handle the diff anymore :(

@BlythMeister
Copy link
Contributor Author

I'll take a look in the morning 🙂

@BlythMeister
Copy link
Contributor Author

i have rebased this (and all my other PRs)

@matthid
Copy link
Member

matthid commented Oct 11, 2018

Thanks I thought stuff would go green again but this azure pipeline thing doesn't seem to be well thought through...

@BlythMeister
Copy link
Contributor Author

:( that's a shame...

matthid
matthid approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@matthid matthid merged commit ce3a2c7 into fsprojects:release/next Oct 11, 2018
@matthid
Copy link
Member

matthid commented Oct 11, 2018

Thanks!

@matthid matthid mentioned this pull request Oct 12, 2018
Merged
@BlythMeister BlythMeister deleted the teamcity branch May 11, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlythMeister @matthid