Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.8.4 #2116

Merged
merged 52 commits into from
Oct 8, 2018
Merged

Release 5.8.4 #2116

merged 52 commits into from
Oct 8, 2018

Conversation

matthid
Copy link
Member

@matthid matthid commented Sep 27, 2018

BlythMeister and others added 25 commits September 25, 2018 16:16
I keep running into dotnet/standard#708 and this is apparently fixed in 2.0.3
Merge pull request #2104 from fsharp/release/next
@matthid matthid changed the title Next Release Release 5.8.1 Sep 27, 2018
Update FakeRuntime to use NetStandard 2.0.3
@matthid matthid changed the title Release 5.8.1 Release 5.8.2 Sep 27, 2018
@BlythMeister
Copy link
Contributor

@matthid any eta on this version? and maybe inclusion of #2114 ?

@BlythMeister
Copy link
Contributor

I would say show stopper when i've tried to use the new SQL Server module...linked to #2007

The module itself won't work as it can't get sni

@matthid
Copy link
Member Author

matthid commented Oct 3, 2018

@BlythMeister what do you mean?

@BlythMeister
Copy link
Contributor

When you try and use the new SQL server module, because it uses system.data.sqlclient the native dependency of the sni doesn't work.
So as soon as you use the module, The execution fails at run time.

@matthid
Copy link
Member Author

matthid commented Oct 3, 2018

Then I guess I’ll uncomment the sql module and not release it until we have a solution?
We need to have a runtime solution for this ‘additional-deps’ doesn’t help.

I’m pretty sure we have all the logic we need to find the dlls but we need to know which apis we need to call to load them

@BlythMeister
Copy link
Contributor

Yes, I think that's best. Maybe worth double checking it's not just me too 😂

@matthid matthid changed the title Release 5.8.2 Release 5.8.4 Oct 5, 2018
@matthid matthid merged commit a11e478 into master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants