-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Core 2.1 #1972
.Net Core 2.1 #1972
Conversation
Release Candidate 17
* Remove obsolete Microsoft.DotNet.Watcher.Tools
Yes the only interesting impact is dotnet-fake because it will no longer work when people have 2.0. Everything else probably doesn't matter that much and we can upgrade |
What is the advantage to updating? Breaking 2.0 without any reason seems .... not good? |
Updating dotnet-fake has no real advantage as far as i can tell. I read that you have to rebuild global cli tools when the full version is released, so fake-cli might not work anymore now for some people. Its working for me though, so i am not sure if that is actually the case. |
@0x53A Updating everything else besides "dotnet-fake" should be "safe" and gets all the performance and runtime improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The only thing is about dotnet-fake
but the rest is probably reasonable. We can release and see what happens :)
xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<TargetFramework>netcoreapp2.1</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why every line changed? Line ending changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-Format on save in vscode. Probably uses the 4 spaces from the editorconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I didn't noticed, thanks. Can we change that for project files to two? Or just leave it as is. Now that I understand whats going on :)
But I think two is what the files use when auto generated (for example via dotnet new
), correct?
xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<TargetFramework>netcoreapp2.1</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider leaving netcoreapp2.0 (or both) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change that later today when i am at home. Do you want both or just 2,0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I guess leaving 2.0 for now is the better option. We just wait until people start complaining.
I also added *.fsproj to the editorconfig to fix the indentation issue. |
@matthid can you please push this out to nuget? |
@kblohm Thanks for taking care of this! |
Hi,
as .Net Core 2.1 was just released, i updated FAKE to use the new version.
I split the update in 2 commits: