Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Core 2.1 #1972

Merged
merged 4 commits into from
Jun 2, 2018
Merged

.Net Core 2.1 #1972

merged 4 commits into from
Jun 2, 2018

Conversation

kblohm
Copy link
Contributor

@kblohm kblohm commented May 30, 2018

Hi,
as .Net Core 2.1 was just released, i updated FAKE to use the new version.
I split the update in 2 commits:

  1. Adds the new version to the DotNet-Module and uses the release version in the build instead of the RC.
  2. Replaces netcore2.0 with 2.1. I am not sure if we want to do this already or maybe just do it for tests and not for fake-dotnet. If we do not want to update yet or not update the tools, i can revert/adjust this one.

@matthid
Copy link
Member

matthid commented May 30, 2018

Yes the only interesting impact is dotnet-fake because it will no longer work when people have 2.0. Everything else probably doesn't matter that much and we can upgrade

@0x53A
Copy link
Contributor

0x53A commented May 30, 2018

What is the advantage to updating? Breaking 2.0 without any reason seems .... not good?

@kblohm
Copy link
Contributor Author

kblohm commented May 31, 2018

Updating dotnet-fake has no real advantage as far as i can tell. I read that you have to rebuild global cli tools when the full version is released, so fake-cli might not work anymore now for some people. Its working for me though, so i am not sure if that is actually the case.

@matthid
Copy link
Member

matthid commented May 31, 2018

@0x53A Updating everything else besides "dotnet-fake" should be "safe" and gets all the performance and runtime improvements.

Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The only thing is about dotnet-fake but the rest is probably reasonable. We can release and see what happens :)

xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why every line changed? Line ending changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-Format on save in vscode. Probably uses the 4 spaces from the editorconfig.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't noticed, thanks. Can we change that for project files to two? Or just leave it as is. Now that I understand whats going on :)
But I think two is what the files use when auto generated (for example via dotnet new), correct?

xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider leaving netcoreapp2.0 (or both) here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change that later today when i am at home. Do you want both or just 2,0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess leaving 2.0 for now is the better option. We just wait until people start complaining.

@matthid matthid changed the base branch from master to release/rc May 31, 2018 12:22
@kblohm
Copy link
Contributor Author

kblohm commented May 31, 2018

I also added *.fsproj to the editorconfig to fix the indentation issue.
If you want me to squash or something, ping :).

@matthid matthid merged commit 85ccbfd into fsprojects:release/rc Jun 2, 2018
@parthopdas
Copy link

@matthid can you please push this out to nuget?

@matthid
Copy link
Member

matthid commented Jun 2, 2018

@kblohm Thanks for taking care of this!
@parthopdas Yes sure, once we made sure everything works on staging ;)

@kblohm kblohm deleted the netcore2.1 branch June 2, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants